Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/push notification #73

Merged
merged 49 commits into from
Nov 14, 2024
Merged

Feat/push notification #73

merged 49 commits into from
Nov 14, 2024

Conversation

DanielGreenEngineer
Copy link
Contributor

@DanielGreenEngineer DanielGreenEngineer self-assigned this Nov 2, 2024
@DanielGreenEngineer DanielGreenEngineer marked this pull request as ready for review November 6, 2024 11:42
TorinAsakura
TorinAsakura requested changes Nov 6, 2024
View reviewed changes
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
personalization-sdk/src/main/kotlin/com/personalization/notification/core/NotificationHelper.kt Outdated Show resolved Hide resolved
TorinAsakura
TorinAsakura requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

короче, очередная порция фарша

...alization-sdk/src/main/kotlin/com/personalization/features/notification/core/ErrorHandler.kt Outdated Show resolved Hide resolved
...on-sdk/src/main/kotlin/com/personalization/features/notification/core/NotificationHandler.kt Outdated Show resolved Hide resolved
...in/com/personalization/features/notification/data/broadcast/NotificationBroadcastReceiver.kt Outdated Show resolved Hide resolved
...main/kotlin/com/personalization/features/notification/data/helpers/NotificationDataMapper.kt Outdated Show resolved Hide resolved
TorinAsakura
TorinAsakura requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@TorinAsakura TorinAsakura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По остальным, аналогичным кускам замечания из той же оперы

...in/com/personalization/features/notification/data/broadcast/NotificationBroadcastReceiver.kt Outdated Show resolved Hide resolved
...in/com/personalization/features/notification/data/broadcast/NotificationBroadcastReceiver.kt Outdated Show resolved Hide resolved
.../main/kotlin/com/personalization/features/notification/data/mapper/NotificationDataMapper.kt Outdated Show resolved Hide resolved
...ain/kotlin/com/personalization/features/notification/data/worker/UpdateNotificationWorker.kt Outdated Show resolved Hide resolved
.../kotlin/com/personalization/features/notification/domain/helpers/NotificationClickHandler.kt Outdated Show resolved Hide resolved
@TorinAsakura TorinAsakura merged commit 0004a16 into master Nov 14, 2024
1 check passed
@TorinAsakura TorinAsakura deleted the feat/push-notification branch November 14, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TorinAsakura TorinAsakura TorinAsakura approved these changes

Assignees

@DanielGreenEngineer DanielGreenEngineer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielGreenEngineer @TorinAsakura